Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo List #19

Open
mwarning opened this issue Mar 4, 2019 · 5 comments
Open

ToDo List #19

mwarning opened this issue Mar 4, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@mwarning
Copy link
Owner

mwarning commented Mar 4, 2019

  • Use Fragments instead of Preference UI classes
    • This would also remove some minor hacks.
  • translations
  • be able to trigger an https open command and a bluetooth door bell
  • parse door return data in various ways (e.g. json) (sort of - regex..)
  • translate to Kotlin
  • differentiate between locked/closed terminology
@mwarning mwarning added the enhancement New feature or request label Mar 5, 2019
@mwarning mwarning changed the title Use Fragments instead of Preference class mashup ToDo List Jan 26, 2020
@stikonas
Copy link

parse door return data in various ways (e.g. json)

This would make app useful for other purposes too, e.g. turning lights on/off. Now LOCKED/UNLOCKED is expected in return data...

@mwarning
Copy link
Owner Author

mwarning commented Jun 21, 2020

Yes, this is rather limited right now. But making it more generic might also is a UI problem.
How to device that that specific value is present? Maybe a regex. But that might be rather complex to type.

@stikonas
Copy link

Regex is probably an overkill. Maybe it's easier to type exact message (similarly to open/close commands).

Regarding UI, that's unfortunately true :(. There are already quite a few fields in that MQTT dialog.

@mwarning
Copy link
Owner Author

mwarning commented Jun 21, 2020

@stikonas I have added two settings that default to LOCKED and UNLOCKED. They can be regular expressions as well. The code is not test yet.

I think it is ok, since the main target are DIY door systems. In use, someone needs to figure out the parameters and then can exchange the setup via QR-Code. :]

@stikonas
Copy link

@stikonas I have added two settings that default to LOCKED and UNLOCKED. They can be regular expressions as well. The code is not test yet.

I think it is ok, since the main target are DIY door systems. In use, someone needs to figure out the parameters and then can exchange the setup via QR-Code. :]

Thanks. It should work. I reviewed the commit, and it looks good to me (I don't really code in Java but it's readable anyway :)).

@yurtpage yurtpage mentioned this issue Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants