Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PendingDeprecationWarning in categorical plots #3819

Closed
wants to merge 1 commit into from

Conversation

staticf0x
Copy link

@staticf0x staticf0x commented Jan 25, 2025

Fixes #3804

The full warning:

PendingDeprecationWarning: vert: bool will be deprecated in a future version. Use orientation: {'vertical', 'horizontal'} instead.

This is a pending deprecation in mpl since 3.10, will become deprecated in 3.11 (matplotlib.axes.Axes.bxp).

I noticed the usage of _version_predates function, please let me know if this change should be also backwards compatible, since orientation was added in mpl 3.10.

Edit: I see there's a merged PR to ignore the warning (microsoft/MLOS#900), which could probably be removed by fixing the kwarg.

@staticf0x staticf0x changed the title Fix PendingDeprecationWarning in categorical plots (#3804) Fix PendingDeprecationWarning in categorical plots Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PendingDeprecationWarning: vert: bool will be deprecated in a future version with box plot
1 participant