Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dtd from ibatis.org and config to use during transform for thos… #6

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

castlec
Copy link
Contributor

@castlec castlec commented Jan 11, 2018

I was forced to make some changes because my work machine doesn't have outside internet access. I needed to use cached dtd. I pulled all of the dtd from mybatis.org and created a new directory to reference them from. I have only referenced sql-map-2, leaving the identification of other publicId as an exercise to others when your code fails them :)

With the creation of a dtd directory, I also changed the reference to cached dtd in validation to pull from dtd directory rather than root.

…e unlucky enough to not be able to access internet without significant difficulty :(
@hazendaz hazendaz marked this pull request as draft November 9, 2023 01:33
@hazendaz
Copy link
Member

hazendaz commented Nov 9, 2023

don't think we need to merge this but rather than close and hide it if others need it, putting it in draft to prevent accidental merge otherwise. I probably would have merged after reviewing it but given it states it will cause users issues and they must figure that out, its not a good candidate to be merged in. Plus I'd like to hope 5 years later folks don't have this issue.

@harawata
Copy link
Member

harawata commented Dec 6, 2024

There is another report for the same (or similar) issue #44 , so I think this is worth merging.
I will try to do some cleaning up (e.g. remove duplicated or non-referenced DTD files) when I have time.

@harawata harawata marked this pull request as ready for review December 7, 2024 13:13
@harawata harawata merged commit 1036550 into mybatis:master Dec 7, 2024
12 checks passed
@harawata harawata self-assigned this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants