some basic tests for the volunteer pages

crowdsourcer/fixtures/users.json

@@ -89,6 +89,24 @@
     "user_permissions": []
   }
 },
+{
+  "model": "auth.user",
+  "pk": 6,
+  "fields": {
+    "password": "",
+    "last_login": null,
+    "is_superuser": false,
+    "username": "volunteer_admin",
+    "first_name": "Volunteer",
+    "last_name": "Admin",
+    "email": "[email protected]",
+    "is_staff": false,
+    "is_active": true,
+    "date_joined": "2022-12-19T13:40:36.075Z",
+    "groups": [],
+    "user_permissions": []
+  }
+},
 {
   "model": "crowdsourcer.marker",
   "pk": 1,
@@ -116,5 +134,14 @@
     "response_type_id": 1,
     "marking_session": [2]
   }
+},
+{
+  "model": "crowdsourcer.marker",
+  "pk": 4,
+  "fields": {
+    "user_id": 2,
+    "response_type_id": 1,
+    "marking_session": [1]
+  }
 }
 ]

crowdsourcer/tests/test_volunteer_views.py

@@ -0,0 +1,194 @@
+from django.contrib.auth.models import Permission, User
+from django.test import TestCase
+from django.urls import reverse
+
+from crowdsourcer.models import (
+    Assigned,
+    Marker,
+    MarkingSession,
+    PublicAuthority,
+    Response,
+    ResponseType,
+    Section,
+)
+
+
+class BaseTestCase(TestCase):
+    fixtures = [
+        "authorities.json",
+        "basics.json",
+        "users.json",
+        "questions.json",
+        "options.json",
+        "assignments.json",
+    ]
+
+    def setUp(self):
+        p = Permission.objects.get(codename="can_manage_users")
+        u = User.objects.get(username="volunteer_admin")
+        u.user_permissions.add(p)
+
+        self.client.force_login(u)
+        self.user = u
+
+
+class TestAccess(TestCase):
+    fixtures = [
+        "authorities.json",
+        "basics.json",
+        "users.json",
+    ]
+
+    user_id = 3
+    urls = [
+        "list_volunteers",
+        "available_authorities",
+        "bulk_assign_volunteer",
+    ]
+    user_urls = [
+        "assign_volunteer",
+        "edit_volunteer",
+    ]
+
+    def test_no_anon_access(self):
+        for url in self.urls:
+            url = reverse(url)
+            response = self.client.get(url)
+            self.assertEqual(response.status_code, 302)
+            self.assertEqual(response.url, f"/accounts/login/?next={url}")
+
+        for url in self.user_urls:
+            url = reverse(url, args=(self.user_id,))
+            response = self.client.get(url)
+            self.assertEqual(response.status_code, 302)
+            self.assertEqual(response.url, f"/accounts/login/?next={url}")
+
+    def test_access_with_no_permissions(self):
+        u = User.objects.get(username="other_marker")
+        self.client.force_login(u)
+        for url in self.urls:
+            url = reverse(url)
+            response = self.client.get(url)
+            self.assertEqual(response.status_code, 403)
+
+        for url in self.user_urls:
+            url = reverse(url, args=(self.user_id,))
+            response = self.client.get(url)
+            self.assertEqual(response.status_code, 403)
+
+    def test_access_with_permissions(self):
+        p = Permission.objects.get(codename="can_manage_users")
+        u = User.objects.get(username="volunteer_admin")
+        u.user_permissions.add(p)
+
+        self.client.force_login(u)
+        for url in self.urls:
+            url = reverse(url)
+            response = self.client.get(url)
+            self.assertEqual(response.status_code, 200)
+
+        for url in self.user_urls:
+            url = reverse(url, args=(self.user_id,))
+            response = self.client.get(url)
+            self.assertEqual(response.status_code, 200)
+
+
+class TestListVolunteers(BaseTestCase):
+    def test_shows_assignments(self):
+        url = reverse("list_volunteers")
+        response = self.client.get(url)
+
+        context = response.context
+
+        volunteers = context["volunteers"]
+        self.assertEqual(len(volunteers), 3)
+
+        emails = [u.email for u in volunteers]
+        self.assertTrue("[email protected]" in emails)
+        self.assertTrue("[email protected]" in emails)
+        self.assertTrue("[email protected]" in emails)
+        self.assertTrue("[email protected]" not in emails)
+
+        v = volunteers[0]
+
+        self.assertEqual(v.email, "[email protected]")
+        self.assertEqual(v.marker.response_type.type, "Audit")
+        self.assertEqual(v.num_assignments, 1)
+
+        v = volunteers[1]
+
+        self.assertEqual(v.email, "[email protected]")
+        self.assertEqual(v.marker.response_type.type, "Right of Reply")
+        self.assertEqual(v.num_assignments, None)
+
+        v = volunteers[2]
+
+        self.assertEqual(v.email, "[email protected]")
+        self.assertEqual(v.marker.response_type.type, "First Mark")
+        self.assertEqual(v.num_assignments, 3)
+
+
+class TestEditVolunteer(BaseTestCase):
+    def test_other_session_user(self):
+        url = reverse("edit_volunteer", args=("5",))
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 404)
+
+    def test_no_op_edit(self):
+        url = reverse("edit_volunteer", args=("2",))
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)
+
+        u = response.context["form"].instance
+
+        self.assertEqual(u.email, "[email protected]")
+
+        response = self.client.post(
+            url,
+            data={
+                "marker-INITIAL_FORMS": 1,
+                "marker-MAX_NUM_FORMS": 1,
+                "marker-MIN_NUM_FORMS": 0,
+                "marker-TOTAL_FORMS": 1,
+                "marker-0-id": u.marker.pk,
+                "marker-0-user": u.pk,
+                "first_name": u.first_name,
+                "last_name": u.last_name,
+                "email": u.email,
+                "username": u.username,
+                "marker-0-response_type": u.marker.response_type.pk,
+            },
+        )
+
+        self.assertRedirects(response, f"/Default{reverse('list_volunteers')}")
+
+    def test_edit(self):
+        url = reverse("edit_volunteer", args=("2",))
+        response = self.client.get(url)
+        u = response.context["form"].instance
+
+        self.assertEqual(u.marker.response_type.type, "First Mark")
+
+        rt = ResponseType.objects.get(type="Audit")
+
+        response = self.client.post(
+            url,
+            data={
+                "marker-INITIAL_FORMS": 1,
+                "marker-MAX_NUM_FORMS": 1,
+                "marker-MIN_NUM_FORMS": 0,
+                "marker-TOTAL_FORMS": 1,
+                "marker-0-id": u.marker.pk,
+                "marker-0-user": u.pk,
+                "first_name": u.first_name,
+                "last_name": u.last_name,
+                "email": u.email,
+                "username": u.username,
+                "marker-0-response_type": rt.pk,
+            },
+        )
+
+        self.assertRedirects(response, f"/Default{reverse('list_volunteers')}")
+
+        u = User.objects.get(id=2)
+        self.assertEqual(u.marker.response_type.type, "Audit")

crowdsourcer/views/volunteers.py

@@ -43,6 +43,7 @@ def get_queryset(self):
                     .values("num_assignments")
                 )
             )
+            .order_by("username")
         )
 
 
@@ -146,6 +147,13 @@ class AvailableAssignmentAuthorities(VolunteerAccessMixin, ListView):
     context_object_name = "authorities"
 
     def get_queryset(self):
+        if (
+            self.request.GET.get("ms") is None
+            or self.request.GET.get("rt") is None
+            or self.request.GET.get("s") is None
+        ):
+            return []
+
         return PublicAuthority.objects.filter(
             questiongroup__marking_session__id=self.request.GET["ms"]
         ).exclude(