Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Questions with previous responses and display on First Mark screen #161

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

struan
Copy link
Member

@struan struan commented Jun 11, 2024

Add a link to the question in the previous marking session, a script to set this and then uses this to display previous responses on the First Mark screen, including a button to copy across the previous data.

Screenshot 2024-06-11 at 14 30 25

@struan struan force-pushed the 142-link-q-across-sessions branch 2 times, most recently from 332489f to 2f60c0b Compare June 12, 2024 10:56
@struan struan requested a review from zarino June 13, 2024 16:15
Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good enough to get it in front of CE UK to test out the ergonomics with some real marking.

Just one small suggestion, inline, about an opportunity to DRY up an SVG icon.


<div class="mb-3">
<button class="btn btn-sm btn-outline-primary d-flex align-items-center js-copy-response-from-previous" type="button">
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="me-2" viewBox="0 0 16 16">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we’re using this "magic wand" icon in a second place, perhaps it’s time we moved it into its own partial, in crowdsourcer/templates/crowdsourcer/icons/? You can use download.svg as an example of how to handle the overrideable class/height/width attributes etc.

@struan struan force-pushed the 142-link-q-across-sessions branch from 0c7f89a to d14f9a6 Compare June 19, 2024 10:58
struan added 3 commits June 19, 2024 11:58
This will enable displaying the previous years answers on the First Mark
screen so they can be used if nothing has changed.
Defaults to matching question numbers across sessions but allows
overrides for where there is not a direct match

Fixes #142
If there are previous questions available then display the answers and
allow the First Markers to copy these across. This might not work for
the options if they have changed but that's ok because if they've
changed then they should be checking them and not copying them.

Fixes #133
@struan struan force-pushed the 142-link-q-across-sessions branch from d14f9a6 to 434809f Compare June 19, 2024 11:02
@struan struan merged commit 434809f into main Jun 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants