Various form changes for WhoFundsThem #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
struan
commented
Sep 25, 2024
•
struan
commented
- Customise labels, help text and which fields are mandatory for forms.
- Make Open/Closed by default for question criteria also configurable.
- Improve display of the skip questions dropdown.
struan
force-pushed
the
customisable-form-labels
branch
2 times, most recently
from
64c6e90 to
de89ec6
Compare
Useful for WFT which has slightly different requirements
Can then adjust style everywhere, plus less duplicate code
If the url had a query param or a # part, e.g. if you'd used the skip to question, then the contructed URL wasn't valid so construct the url from parts instead
struan
force-pushed
the
customisable-form-labels
branch
from
de89ec6 to
25d60d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.