DATASET: Air pollution data #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 84.68% 84.59% -0.09%
==========================================
Files 75 76 +1
Lines 2500 2512 +12
Branches 249 250 +1
==========================================
+ Hits 2117 2125 +8
- Misses 323 326 +3
- Partials 60 61 +1
|
zarino
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
@alexander-griffen Hope you don’t mind, I’ve added a commit that changes how this data is presented in the front end. Should probably squash my commit into your second commit, before merging.
So we can keep track of, and display, when the data was released.
The file which is used to match the 'gridcode' value to the constituency code was created using shapefiles of constituencies re-projected onto the same projection as the defra data (BNG 27700), and one example of the gridcodes to x and y values as found from an arbitrary input file for this import. QGIS was used to find where the points were within the boundaries of the constituencies, and indeed which constituencies. To prevent this process having to be repeated, the output file is stored in the Drive
struan
force-pushed
the
180-air-quality-data
branch
from
eba5266 to
5a313ac
Compare
This change includes an addition of a filter, which allows for rendering of subscript written in shorthand (https://pages.uoregon.edu/ncp/Courses/MathInPlainTextEmail.html). Currently, this new filter only works if there is only one instance of subscript, and that it's at the end of the string.
struan
force-pushed
the
180-air-quality-data
branch
from
5a313ac to
8243066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
Implementation notes
Data import of various air pollution data models Defra have produced (that I assume are the basis for some of the data mentioned in the ticket). This data was recorded in 2021.
The geo-matching was performed in GIS, and uploaded to the Drive (explained in more detail in 934f547).
Subscript is currently handled as follows:
Next steps
The table (image above) could include more detail on the metric. Below is it as a separate column to show the relevant data (which is stored in the
descriptionattribute of theDataTypeobject), although that column isn't present in the code, because it looks bad. The subscript and superscript is present as unicode here, so shouldn't require fancy handling.