Descriptions + release dates #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-griffen
force-pushed
the
192-store-display-dataset-dates-descriptions
branch
2 times, most recently
from
eb11b1e to
8ed4cd6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 82.50% 82.24% -0.26%
==========================================
Files 87 87
Lines 2669 2636 -33
Branches 275 275
==========================================
- Hits 2202 2168 -34
Misses 404 404
- Partials 63 64 +1 ☔ View full report in Codecov by Sentry. |
alexander-griffen
force-pushed
the
192-store-display-dataset-dates-descriptions
branch
3 times, most recently
from
9c63c94 to
6b2de17
Compare
alexander-griffen
changed the title
struan
requested changes
Nov 20, 2023
There is a separate, more up-to-date fuel import dataset that exists in the app, and this import isn't used. The test for this import is also removed.
alexander-griffen
force-pushed
the
192-store-display-dataset-dates-descriptions
branch
from
6b2de17 to
e1e4d72
Compare
|
Also need to change the templates to show release dates, and change source attributions |
alexander-griffen
force-pushed
the
192-store-display-dataset-dates-descriptions
branch
from
e1e4d72 to
e021a98
Compare
This commit covers updates to all of the dataset import scripts, ensuring that their release date, description, and source label are what is expected (according to the 'crowdsourcing' sheet).
This change also removes part of the MP import script that runs all the MP-related scripts, to avoid redundancy
alexander-griffen
force-pushed
the
192-store-display-dataset-dates-descriptions
branch
from
e021a98 to
b724241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192 and fixes #304