Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display PPCs where appropriate #372

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Conversation

struan
Copy link
Member

@struan struan commented Dec 14, 2023

Fixes #351

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (59a6179) 84.38% compared to head (5138236) 84.38%.

Files Patch % Lines
hub/views/area.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           multiple-geometry-staging     #372      +/-   ##
=============================================================
- Coverage                      84.38%   84.38%   -0.01%     
=============================================================
  Files                             94       96       +2     
  Lines                           2761     2773      +12     
  Branches                         277      279       +2     
=============================================================
+ Hits                            2330     2340      +10     
- Misses                           365      366       +1     
- Partials                          66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-griffen
Copy link
Contributor

Added this to the appropriate area pages:
image

@alexander-griffen alexander-griffen marked this pull request as ready for review December 19, 2023 15:27
@alexander-griffen alexander-griffen self-assigned this Dec 19, 2023
@zarino
Copy link
Member

zarino commented Dec 19, 2023

@alexander-griffen quick question! Do you think we’d be able to get the candidate’s photo (if it exists) from the Democracy Club source too? eg: https://whocanivotefor.co.uk/person/6042

If so, here’s how I imagined it being displayed on the upcoming constituency page:

candidates

Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the area page markup/styling is all about to get changed in #349, I’m not that bothered about the new markup here. Seems fine for now.

We’ll need to wait for @struan to get back, to review the rest of this before merging and deploying.

@struan struan mentioned this pull request Jan 9, 2024
11 tasks
@struan struan force-pushed the multiple-geometry-staging branch from 6bec7e1 to 59a6179 Compare January 11, 2024 10:07
This is to enable use to indicate when an MP's term has expired.
makes no difference at the moment as all MPs are current.
@struan struan force-pushed the 351-new-cons-ppcs branch from acf0ce2 to 74cceb7 Compare January 11, 2024 11:11
@struan struan force-pushed the 351-new-cons-ppcs branch from 74cceb7 to b2f7aeb Compare January 11, 2024 11:55
@struan
Copy link
Member Author

struan commented Jan 11, 2024

FWIW I've updated the display on this to look like:

Screenshot 2024-01-11 at 11 56 14

And created a ticket for the photos: #379

@zarino
Copy link
Member

zarino commented Jan 11, 2024

@struan – looks good, I’ve added a card-footer to the cards, which credits Democracy Club.

@struan struan merged commit 5138236 into multiple-geometry-staging Jan 11, 2024
7 checks passed
@zarino zarino linked an issue Jan 16, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display prospective parliamentary candidates for 2025 constituencies
3 participants