-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display PPCs where appropriate #372
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## multiple-geometry-staging #372 +/- ##
=============================================================
- Coverage 84.38% 84.38% -0.01%
=============================================================
Files 94 96 +2
Lines 2761 2773 +12
Branches 277 279 +2
=============================================================
+ Hits 2330 2340 +10
- Misses 365 366 +1
- Partials 66 67 +1 ☔ View full report in Codecov by Sentry. |
5ce8e2a
to
b30ce77
Compare
@alexander-griffen quick question! Do you think we’d be able to get the candidate’s photo (if it exists) from the Democracy Club source too? eg: https://whocanivotefor.co.uk/person/6042 If so, here’s how I imagined it being displayed on the upcoming constituency page: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6bec7e1
to
59a6179
Compare
This is to enable use to indicate when an MP's term has expired.
makes no difference at the moment as all MPs are current.
acf0ce2
to
74cceb7
Compare
74cceb7
to
b2f7aeb
Compare
FWIW I've updated the display on this to look like: ![]() And created a ticket for the photos: #379 |
@struan – looks good, I’ve added a |
Fixes #351