[#1840] Donation link #1960
Open
[#1840] Donation link #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mysociety` (`/donate`), add missing comma.
mdeuk
commented
Jan 27, 2025
Comment on lines
+6
to
+7
| mySociety is a charity that believes that information should be accessible to everyone. | ||
| If this is important to you, please consider donating to help us do more: |
There was a problem hiding this comment.
I realise this is a little long, but it didn't seem like it would flow as well if there was another linebreak (e.g. before 'accessible').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
#1840
What does this do?
This adds a new route,
/donate, which points toward the WDTK specific donation page.It also adds the enhanced "please donate" wording, from #1840 (comment)
Why was this needed?
Current mailbox signature has a rather cumbersome link, this enables a neater solution.
Additionally, the enhanced "ask" is hopefully more eye catching, within the limit that plaintext email has.
Implementation notes
Nothing new here, it's just enhancing what is already in the code.
Screenshots
Notes to reviewer
I'm not sure if this closes #1840 completely, or not, so haven't marked it as such.