Improvement/naive detection of nat #292
Conversation
tadovas
force-pushed
the
improvement/naive-detection-of-NAT
branch
from
064c483 to
5195372
Compare
… the same as outbound ip
tadovas
force-pushed
the
improvement/naive-detection-of-NAT
branch
from
5195372 to
4c52040
Compare
| @@ -105,7 +110,16 @@ func (cmd *Command) Start() (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| sessionManager := cmd.sessionManagerFactory(primitives, vpnServerIP) | |||
| if outboundIP != publicIP { | |||
| log.Infof( | |||
There was a problem hiding this comment.
It's just a warning - not an error
| // if for some reason we will need truly external IP, use GetPublicIP() | ||
| vpnServerIP, err := cmd.ipResolver.GetOutboundIP() | ||
| outboundIP, err := cmd.ipResolver.GetOutboundIP() |
There was a problem hiding this comment.
Aren't we doing option openvpn.ip with this?
For those who wants has different public IP and wats to map it in router
There was a problem hiding this comment.
There is not such option at the moment. And this is a quick detection with posibility for user to take some action.
| forwardInfo := fmt.Sprintf("%s:%v -> %s:%v", publicIP, options.OpenvpnPort, outboundIP, options.OpenvpnPort) | ||
| log.Warnf( | ||
| `WARNING: It seems that publicaly visible ip: [%s] does not match your local machines ip: [%s]. | ||
| You should probaly need to do port forwarding on your router: %s.`, |
There was a problem hiding this comment.
..on your router: PUBLIC_IP:1194 -> MACHINE_IP:1194 e.g. %s:1194->%s:1194
and you can put example values from detected values
There was a problem hiding this comment.
Sorry, did not see that it's already like that
| @@ -76,14 +77,14 @@ func (cmd *Command) Start() (err error) { | |||
| providerContact, err := cmd.dialogWaiter.Start() | |||
|
|
|||
| // if for some reason we will need truly external IP, use GetPublicIP() | |||
| vpnServerIP, err := cmd.ipResolver.GetOutboundIP() | |||
| outboundIP, err := cmd.ipResolver.GetOutboundIP() | |||
There was a problem hiding this comment.
Sad that we do 2-3 requests. Is it possible to avoid it?
There was a problem hiding this comment.
Without too much refactoring? Yes - by passing outboundIP to openvpnServiceAddress function as parameter instead of looking up it again inside. I can live with this approach :)
There was a problem hiding this comment.
Fixed :) reduced ipify query to 1 request
No description provided.