Merge pull request #121 from nabla-studio/davidesegullo/fix-publish

Davidesegullo/fix publish
nabla-studio · Oct 26, 2024 · 1720404 · 1720404
2 parents dce20ba + c4e2397
commit 1720404
Show file tree

Hide file tree

Showing 11 changed files with 29 additions and 35 deletions.
diff --git a/.github/workflows/pr-checks.yml b/.github/workflows/pr-checks.yml
@@ -56,6 +56,13 @@ jobs:
       - name: Run Nx release version (dry-run)
         run: bun run tools/scripts/release.ts
 
-      # Step 9: Clean up dist directory
+      # Step 9: Run publish in dry-run mode
+      - name: Publish
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NPM_CONFIG_PROVENANCE: true
+        run: bunx nx release publish --verbose --dry-run
+
+      # Step 10: Clean up dist directory
       - name: Cleanup dist directory
         run: rm -rf ./dist  # Remove the dist directory to start fresh
diff --git a/.github/workflows/release-preview.yml b/.github/workflows/release-preview.yml
@@ -63,11 +63,15 @@ jobs:
 
       # Step 9: Run the release
       - name: Run Nx release version
-        env: 
+        run: bun run tools/scripts/release.ts -d false
+
+      # Step 10: Run publish
+      - name: Publish
+        env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
-        run: bun run tools/scripts/release.ts -d false
+        run: bunx nx release publish --verbose --tag $RELEASE_TAG
 
-      # Step 10: Clean up dist directory
+      # Step 11: Clean up dist directory
       - name: Cleanup dist directory
         run: rm -rf ./dist  # Remove the dist directory to start fresh
diff --git a/.github/workflows/release-production.yml b/.github/workflows/release-production.yml
@@ -61,11 +61,15 @@ jobs:
 
       # Step 9: Run the release
       - name: Run Nx release version
-        env: 
+        run: bun run tools/scripts/release.ts -d false
+
+      # Step 10: Run publish
+      - name: Publish
+        env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
-        run: bun run tools/scripts/release.ts -d false
+        run: bunx nx release publish --verbose
 
-      # Step 10: Clean up dist directory
+      # Step 11: Clean up dist directory
       - name: Cleanup dist directory
         run: rm -rf ./dist  # Remove the dist directory to start fresh
diff --git a/bun.lockb b/bun.lockb
diff --git a/packages/next/package.json b/packages/next/package.json
@@ -18,7 +18,7 @@
     "cookies-next": "^4.2.1",
     "superjson": "^2.2.1",
     "zustand": "^4.5.0",
-    "@quirks/store": "0.27.2-next.0"
+    "@quirks/store": "0.27.2-next.1"
   },
   "peerDependencies": {
     "next": "^13"

diff --git a/packages/react-native/package.json b/packages/react-native/package.json
@@ -16,7 +16,7 @@
   "sideEffects": false,
   "type": "module",
   "dependencies": {
-    "@quirks/store": "0.27.2-next.0",
+    "@quirks/store": "0.27.2-next.1",
     "@quirks/core": "0.19.1-next.1",
     "babel-plugin-module-resolver": "^5.0.0",
     "@craftzdog/react-native-buffer": "^6.0.5",

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -15,7 +15,7 @@
   "sideEffects": false,
   "type": "module",
   "dependencies": {
-    "@quirks/store": "0.27.2-next.0",
+    "@quirks/store": "0.27.2-next.1",
     "@quirks/core": "0.19.1-next.1",
     "cosmjs-types": "^0.9.0",
     "@cosmjs/amino": "^0.32.2",

diff --git a/packages/vue/package.json b/packages/vue/package.json
@@ -15,7 +15,7 @@
   "sideEffects": false,
   "type": "module",
   "dependencies": {
-    "@quirks/store": "0.27.2-next.0",
+    "@quirks/store": "0.27.2-next.1",
     "@quirks/core": "0.19.1-next.1",
     "vue-zustand": "^0.6.0",
     "eventemitter3": "^5.0.1",

diff --git a/packages/wallet-registry/README.md b/packages/wallet-registry/README.md
@@ -1,11 +1,3 @@
 # wallet-registry
 
-This library was generated with [Nx](https://nx.dev).
-
-## Building
-
-Run `nx build wallet-registry` to build the library.
-
-## Running unit tests
-
-Run `nx test wallet-registry` to execute the unit tests via [Jest](https://jestjs.io).
+This library defines data structure from wallet registry, it's helpful to retrieve official metadata for wallet connect and also allow us to access wallet details.
diff --git a/tools/scripts/release.ts b/tools/scripts/release.ts
@@ -39,19 +39,6 @@ const release = async () => {
       dryRun: options.dryRun,
       verbose: options.verbose,
     });
-
-    // The returned number value from releasePublish will be zero if all projects are published successfully, non-zero if not
-    if (!options.dryRun) {
-        const publishStatus = await releasePublish({
-            dryRun: options.dryRun,
-            verbose: options.verbose,
-            tag,
-        });
-
-        const code = Math.max(...Object.values(publishStatus).map(({ code }) => code))
-
-        process.exit(code);
-    }
 
     process.exit();
 }

diff --git a/yarn.lock b/yarn.lock
@@ -5025,7 +5025,7 @@
   dependencies:
     "@types/yargs-parser" "*"
 
-"@types/yargs@^17.0.8", "@types/yargs@^17.0.33":
+"@types/yargs@^17.0.33", "@types/yargs@^17.0.8":
   version "17.0.33"
   resolved "https://registry.npmjs.org/@types/yargs/-/yargs-17.0.33.tgz"
   integrity sha512-WpxBCKWPLr4xSsHgz511rFJAM+wS28w2zEO1QDNY5zM/S8ok70NNfztH0xwhqKyaK0OHCbN98LDAZuy1ctxDkA==
@@ -18959,7 +18959,7 @@ yargs@^15.1.0, yargs@^15.3.1:
     require-directory "^2.1.1"
     require-main-filename "^2.0.0"
 
-yargs@^17.0.0, yargs@^17.3.1, yargs@^17.5.1, yargs@^17.6.2, yargs@^17.7.2, yargs@^17.7.2:
+yargs@^17.0.0, yargs@^17.3.1, yargs@^17.5.1, yargs@^17.6.2, yargs@^17.7.2:
   version "17.7.2"
   resolved "https://registry.npmjs.org/yargs/-/yargs-17.7.2.tgz"
   integrity sha512-7dSzzRQ++CKnNI/krKnYRV7JKKPUXMEh61soaHKg9mrWEhzFWhFnxPxGl+69cD1Ou63C13NUPCnmIcrvqCuM6w==