Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent package caching in Docker images #288

Merged
merged 3 commits into from
Jan 17, 2024
Merged

prevent package caching in Docker images #288

merged 3 commits into from
Jan 17, 2024

Conversation

CarlinLiao
Copy link
Collaborator

Closes #274. All tests pass. Ideally, I'd like to bring back the workflow Docker image in this PR as well to serve #287.

@CarlinLiao CarlinLiao added the enhancement New feature or request label Jan 17, 2024
@CarlinLiao CarlinLiao self-assigned this Jan 17, 2024
@CarlinLiao CarlinLiao changed the title prevent pip caching prevent package caching in Docker images Jan 17, 2024
@jimmymathews
Copy link
Collaborator

jimmymathews commented Jan 17, 2024

The images are indeed smaller. I did a release with the version bumps so this is ready to merge as soon as tests pass.

@jimmymathews jimmymathews merged commit e3f7fd4 into main Jan 17, 2024
1 check passed
CarlinLiao added a commit that referenced this pull request Jan 17, 2024
* prevent pip caching

* Doing version bumps to prepare for release of images with new caching setup

* Attempt to keep apt caching to a minimum.

---------

Co-authored-by: James Mathews <[email protected]>
jimmymathews added a commit that referenced this pull request Jan 19, 2024
* remove network option, start adding singularity

* fix some typos

* deprecate lsf support and clean up container workflow option

* add rule to publish spt-development image as nadeemlab/spt

* prevent package caching in Docker images (#288)

* prevent pip caching

* Doing version bumps to prepare for release of images with new caching setup

* Attempt to keep apt caching to a minimum.

---------

Co-authored-by: James Mathews <[email protected]>

* fix some typos and add the retag

* one character typo

* Make UMAP test actually check status

* remove unnecessary runOptions from nextflow singularity

* pin image used for each workflow

* move cuda image determination upstream

* update graph workflow docs

* improve doc flow

* ensure singularity training is provided GPU(s)

* add a note about singularity env variable settings

* fix db config copy in nextflow

* Soften warning language

* Version bump of spatialprofilingtoolbox

---------

Co-authored-by: James Mathews <[email protected]>
Co-authored-by: James Mathews <[email protected]>
@CarlinLiao CarlinLiao deleted the issue274 branch January 20, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would adding --no-cache-dir to pip install commands slim down Docker image sizes?
2 participants