Supply UMAP position information as virtual slide #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a "virtual sample"
…pect the given database config file contents
|
There is also a new flag in the study summary, |
|
All tests pass except that it seems that there is a test (unrelated to this PR) which is not completely deteriministic (ripley). Might need to search harder for the location to set a random seed, or else relax the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not merged yet, but I released the application images for frontend development purposes.
The functionality unrelated to UMAPs seems unaffected.
You can get the new data just by supplying the sample name "UMAP virtual slide":
View it with:
I think we should wait to merge until we have tested it in the frontend.