Re-export os::<platform>::Symbol
from top-level as RawSymbol
#95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to name the underlying raw lifetime-less
Symbol
type in a cross-platform manner without the user adding someplatform-specific compiler flags and re-exporting it from each
os
module themselves, e.g. something like:
The idea behind this PR is to allow users to refer to the type directly
as
libloading::RawSymbol
.Motivation: I'm currently using
libloading
in a project where I'mhot-loading a handful of very hot functions. Rather than load the
Symbol
on every frame I thought I'd load them once and store the rawsymbol alongside the
Library
, though realised theos::platform::Symbol
path mentioned in the docs doesn't exist andquickly ran into the issue mentioned above.
@nagisa let me know if something like this sounds OK or if I'm missing something!