Fix use after free replication data block

During replStreamProgressCallback replica may recive replicaof command and hance free replica side replicaiton buffer. If replication buffer is freed we should abort the streaming Signed-off-by: naglera <[email protected]>
naglera · Jun 10, 2024 · 15905e7 · 15905e7
1 parent 0fa3260
commit 15905e7
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/replication.c b/src/replication.c
@@ -2942,6 +2942,11 @@ void streamReplDataBufToDb(client *c) {
         processInputBuffer(c);
         server.pending_repl_data.len -= o->used;
         replStreamProgressCallback(offset, o->used, &last_progress_callback);
+        if (!server.pending_repl_data.blocks) {
+            /* If we processed replicaof command during replStreamProgressCallback, then
+             * we should abort replication data streaming ASAP. */
+            break;
+        }
         offset += o->used;
         listDelNode(server.pending_repl_data.blocks, cur);
     }