Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gauge: #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

gauge: #45

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2020

  • Added dialAnglePadding param..
  • Added support to switch the value path with the dial background path.
  • Added value cursor support (line and

gauge:
bba6182 
* Added dialAnglePadding param..
* Added support to switch the value path with the dial background path.
* Added value cursor support (line and
avshalomt2
avshalomt2 suggested changes Oct 18, 2020
View reviewed changes
src/gauge.js Outdated Show resolved Hide resolved
src/gauge.js Outdated Show resolved Hide resolved
src/gauge.js Outdated Show resolved Hide resolved
src/gauge.js Show resolved Hide resolved
src/gauge.js Show resolved Hide resolved
src/gauge.js Outdated Show resolved Hide resolved
avshalomt2
avshalomt2 suggested changes Oct 18, 2020
View reviewed changes
Copy link

@avshalomt2 avshalomt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add documentation of the parameter in the README file
  • Add some example in the example app

@naikus
Copy link
Owner

naikus commented Oct 19, 2020

Hi @medigate-io-dev @avshalomt2 , Thanks for this!
Is there a demo of showcasing how it looks/behaves? Probably codepen?
Also its difficult to see the actual changes with all the indentation changes going around :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naikus @avshalomt2