Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SC-26255] ✨ Introduce NameGuardSummary and EFP components to n… #597

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: [SC-26255] ✨ Introduce NameGuardSummary and EFP components to n… #597

wants to merge 2 commits into from
+2,860 −356

Conversation

FrancoAguzzi
Copy link
Collaborator

…amegraph.dev

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6ba5734

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "ensnode.io" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@vercel Vercel
Copy link

vercel bot commented Feb 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples.nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:25am
nameai.dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:25am
namegraph.dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:25am
nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:25am
namehashlabs.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:25am
namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:25am
storybook.namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:25am

lightwalker-eth
lightwalker-eth approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi Hey super cool updates! 😄 👍 🚀 !! Shared some small suggestions with feedback. Please take the lead on merging in this PR as soon as you're able to action the follow up requests 👍

apps/namegraph.dev/components/name/nameguard-summary.tsx Show resolved Hide resolved
apps/namegraph.dev/app/name/[name]/name-details-page.tsx Outdated Show resolved Hide resolved
apps/namegraph.dev/app/name/[name]/name-details-page.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightwalker-eth lightwalker-eth lightwalker-eth approved these changes

@djstrong djstrong Awaiting requested review from djstrong djstrong is a code owner

@Carbon225 Carbon225 Awaiting requested review from Carbon225 Carbon225 is a code owner

@notrab notrab Awaiting requested review from notrab notrab is a code owner

@BanaSeba BanaSeba Awaiting requested review from BanaSeba BanaSeba is a code owner

@eduramme eduramme Awaiting requested review from eduramme eduramme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrancoAguzzi @lightwalker-eth