-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextsimdg test cycling DA on betzy #9
Open
myying
wants to merge
18
commits into
develop
Choose a base branch
from
nextsimdg
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcorr is with unit (unlike in fortran code) so scorr here don't need to divide by dx
the namelist option "init_file" meant for the very first initial condition file, not the restart file during cycling; to link the first cycle restart file, we need to keep time_start in kwargs during cycling, restart files will be copied over, not linked over, since DA step will update the restart file, making it a new copy
restart at first cycle perturbed seems to cause forecast to fail, removed perturb:restart option; only perturb the forcing for now. add parallel_mode options in slurm.py job submitter, to allow running openmp program in single-job mode (spawning multiple model.run in a big allocation using srun). The job script is scripts/nextsim.dg.test.submit.sh
only show the messages when c.debug=True
if variable is in a group: e.g. data/tair, the assert on variable name in f.variables is not working. use try-catch instead f['data/tair'] shall work
renamed scripts/diag.py to scripts/diagnose.py
f.variables doesn't work for compound varname, change the way to assert variable is in file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on previous PR #7, and PR #8 , I've tested nextsimdg model ensemble forecasts on betzy.sigma2.no computers. Found a few further issues and resolved in the following commits.
I'm now testing nextsimdg model DA code assimilating some OSISAF routine observations. Cherry-picking some development of the data assimilation code from "other_features" branch, will also include these commits in this PR.