Skip to content

Commit

Permalink
ci: remove pyspark from Windows CI (#1998)
Browse files Browse the repository at this point in the history
  • Loading branch information
EdAbati authored Feb 13, 2025
1 parent 381309d commit e8b5c6d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,13 @@ jobs:
cache-suffix: ${{ matrix.python-version }}
cache-dependency-glob: "pyproject.toml"
- name: install-reqs
# we are not testing pyspark on Windows here because it is very slow
run: uv pip install -e ".[tests, core, extra, dask, modin]" --system
- name: install pyspark
run: uv pip install -e ".[pyspark]" --system
# PySpark is not yet available on Python3.12+
if: matrix.python-version != '3.12'
- name: show-deps
run: uv pip freeze
- name: Run pytest
run: |
pytest tests --cov=narwhals --cov=tests --runslow --cov-fail-under=95 --all-cpu-constructors
pytest tests --cov=narwhals --cov=tests --runslow --cov-fail-under=95 --constructors=pandas,pandas[nullable],pandas[pyarrow],pyarrow,modin[pyarrow],polars[eager],polars[lazy],dask,duckdb
pytest-full-coverage:
strategy:
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def pytest_generate_tests(metafunc: pytest.Metafunc) -> None:
selected_constructors = [
x
for x in selected_constructors
if x not in GPU_CONSTRUCTORS and x not in "modin" # too slow
if x not in GPU_CONSTRUCTORS and x != "modin" # too slow
]
else: # pragma: no cover
selected_constructors = metafunc.config.getoption("constructors").split(",")
Expand Down

0 comments on commit e8b5c6d

Please sign in to comment.