CMR-10242: Fix /items/ path for collections which have granule metadata
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eudoroolivares2016
changed the title
/items/ path for collections which have granule metadata
eudoroolivares2016
requested review from
dpesall,
eudoroolivares2016,
william-valencia and
dmistry1
| @@ -24,7 +24,7 @@ describe("addItemLinkIfPresent", () => { | |||
|
|
|||
| const numberoOfLinks = stacCollection.links.length; | |||
| // Invoke method | |||
| addItemLinkIfPresent(stacCollection, "https://foo.com/items"); | |||
There was a problem hiding this comment.
We were talking about this on slack and I'm not sure I understand. Is it the case that this part of the url 'items' is going to be in the actual metadata and thus if we append it going to cause a problem?
There was a problem hiding this comment.
In the case of CMR collections with granules, the metadata will not contain a URL for the items endpoint, it is inferred and generated in code. CMR collections without granules and a STAC related url will have their link pulled from metadata.
eudoroolivares2016
approved these changes
Nov 6, 2024
dmistry1
approved these changes
Nov 6, 2024
eudoroolivares2016
changed the title
/items/ path for collections which have granule metadata/items/ path for collections which have granule metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /items path was missing from rel=items links belonging to collections who have granule metadata in CMR. This resolves that problem. Needs to be addressed before the next release to UAT.