-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4351: Implements AWS CDK #1849
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 93.38% 84.03% -9.35%
==========================================
Files 778 779 +1
Lines 19022 19064 +42
Branches 4911 4920 +9
==========================================
- Hits 17764 16021 -1743
- Misses 1168 2907 +1739
- Partials 90 136 +46 ☔ View full report in Codecov by Sentry. |
"postplaywright": "npx nyc report --reporter=json --reporter=lcov --reporter=clover --report-dir=playwright-coverage", | ||
"deploy-infrastructure": "cd cdk/earthdata-search-infrastructure && npm ci --include=dev && npm run cdk deploy -- --progress events --require-approval never", | ||
"deploy-application": "cd cdk/earthdata-search && npm ci --include=dev && npm run cdk deploy -- --progress events --require-approval never", | ||
"deploy-static": "cd cdk/earthdata-search-static && npm ci --include=dev && npm run cdk deploy -- --progress events --require-approval never" | ||
}, | ||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install --include=optional sharp
npm i @rollup/rollup-darwin-x64
I needed to install these two locally to get my env to work. The rollup I think was a originally coming in from serverless framework
})) | ||
|
||
// Wait for 5 seconds before polling again | ||
setTimeout(pollMessages, 5000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any performance issues with continuously polling the queues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I have noticed, but it is an optional piece to run the application locally. The majority of things we do we don't need to run SQS at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested that:
- Ensure basic application start up etc
- Ensure invoking a lambda works
- Ensure we can use the admin pages
- Ensure that new code changes get picked up
- Step functions work
- Redis cache works
- Admin fails if you change the admin list locally
- Local s3 works
All worked locally
Changes look good, but it looks like CodeCov says it's still missing coverage on a few files. Approved under the assumption that these will be covered. |
The only file the report is calling out that has significant changes is |
Overview
What is the feature?
Implements AWS CDK
What areas of the application does this impact?
New deployment process, new local environment
Testing
Local env testing: follow README updates to set up local env, general testing of app
Checklist