MMT-3895: Now pulls in ALL selected collections. #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 97.52% 97.66% +0.13%
==========================================
Files 362 362
Lines 5540 5565 +25
Branches 1155 1162 +7
==========================================
+ Hits 5403 5435 +32
+ Misses 136 129 -7
Partials 1 1 ☔ View full report in Codecov by Sentry. |
mandyparson
approved these changes
Sep 24, 2024
| @@ -270,7 +270,7 @@ describe('CollectionSelector', () => { | |||
|
|
|||
| await user.type(searchField, 'C') | |||
|
|
|||
| expect(await screen.findByText('Showing 2 items')).toBeInTheDocument() | |||
| expect(await screen.findByText('Showing 1 items')).toBeInTheDocument() | |||
There was a problem hiding this comment.
Why did this change to 1 again?
There was a problem hiding this comment.
I'm not sure, but the mock only has 1 collection as the result. So it is correct.
htranho
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
A user reported that its primary access policy that exposes > 800 collections in ops was reduced to only 20 collections after a update the ACL.
What is the Solution?
The selected collections pane was only retrieving 20 collections, even though the ACL could have many more. Therefore, when the ACL was updated, it would only update with the 20 collections it retrieved and not the full list of collections in the ACL.
The solution is to use fetchMore provided by Apollo to request all the collections in the ACL.
What areas of the application does this impact?
The collection permissions page.
Testing
Try finding a ACL that has over 20 collections (or create a ACL that includes more than 20). Verify you can add and remove collections. Verify all collections you add show up in the right pane and the submit works properly with your additions and subtractions.
Checklist