Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3907: Updated provider dropdown so it is disabled on updating the ACL. Only creation of the ACL will it be enabled. #1310

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

cgokey
Copy link
Collaborator

@cgokey cgokey commented Oct 4, 2024

Overview

What is the feature?

The provider combo box should not allow someone to change the ACL's provider on updating the ACL.

What is the Solution?

If the user is updating the ACL (i.e., adding/removing collections and other updates), the provider combo box should be disabled.

If the user is creating a new ACL, it should be enabled.

What areas of the application does this impact?

ACL permissions creation and updating.

Testing

Reproduction steps

Verify that when updating ACL permissions, the provider combo box is disabled.

Verify that when creating ACL permissions, the provider combo box is enabled.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cgokey cgokey requested review from mandyparson and htranho October 4, 2024 12:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (c54d427) to head (b4ecb7e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
- Coverage   97.66%   97.66%   -0.01%     
==========================================
  Files         362      362              
  Lines        5613     5610       -3     
  Branches     1170     1168       -2     
==========================================
- Hits         5482     5479       -3     
  Misses        130      130              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgokey cgokey merged commit 1d4ad7a into main Oct 4, 2024
5 of 7 checks passed
@cgokey cgokey deleted the MMT-3907b branch October 4, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants