Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3912: Instrument Long Name not populate in the JSON when populated in MMT Forms #1312

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

htranho
Copy link
Contributor

@htranho htranho commented Oct 14, 2024

Overview

What is the feature?

Duplicated instrument name causes the issue that no long name shows up in json view.

What is the Solution?

Use type, subtype and short name to create key for long name map. Add title and tooltip to select box entries to ease selection of duplicated instrument names.

What areas of the application does this impact?

Instrument list and 'Composed Of' in Platforms (Acquisition Information)

Testing

Instrument list should show titles to group entries in the select box and each entry has a tooltip which shows type>subtype

Attachments

N/A

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@htranho htranho requested review from mandyparson and cgokey October 14, 2024 22:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.68%. Comparing base (0ea1eca) to head (2947469).

Files with missing lines Patch % Lines
...s/uiSchemas/collections/acquisitionInformation.jsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   97.66%   97.68%   +0.01%     
==========================================
  Files         362      364       +2     
  Lines        5615     5733     +118     
  Branches     1182     1190       +8     
==========================================
+ Hits         5484     5600     +116     
- Misses        130      132       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@htranho htranho merged commit 29f5050 into main Oct 18, 2024
5 of 7 checks passed
@htranho htranho deleted the MMT-3912 branch October 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants