-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mmt 3922: User is experiencing an issue with MMT deleting information added even after hitting "Save and Continue." #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 364 365 +1
Lines 5733 5740 +7
Branches 1202 1193 -9
=======================================
+ Hits 5600 5607 +7
Misses 132 132
Partials 1 1 ☔ View full report in Codecov by Sentry. |
cgokey
reviewed
Oct 18, 2024
cgokey
reviewed
Oct 18, 2024
cgokey
reviewed
Oct 18, 2024
cgokey
reviewed
Oct 18, 2024
static/src/js/components/MetadataForm/__tests__/MetadataForm.test.jsx
Outdated
Show resolved
Hide resolved
cgokey
reviewed
Oct 21, 2024
cgokey
reviewed
Oct 21, 2024
cgokey
reviewed
Oct 22, 2024
static/src/js/providers/AppContextProvider/AppContextProvider.jsx
Outdated
Show resolved
Hide resolved
cgokey
reviewed
Oct 22, 2024
static/src/js/providers/AppContextProvider/AppContextProvider.jsx
Outdated
Show resolved
Hide resolved
cgokey
approved these changes
Oct 22, 2024
htranho
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
When users would click Save & Continue, occationaly an incorrect version of the draft would populate. This code triggers a useEffect if the revisionId that comes back from CMR does not match the revisionId that we expect.
What is the Solution?
Add revisionId to AppContextProvider and set it when a user ingests a draft. This triggers a change in the data which triggers a fetchdraft useeffect.
What areas of the application does this impact?
MetadataForm and AppContextProvider
Testing
Reproduction steps
console.log("🚀 ~ useEffect ~ cmrRetrievedRevisionId:", cmrRetrievedRevisionId)
console.log("🚀 ~ useEffect ~ appContextRevisionId:", appContextRevisionId)
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist