Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3944: Adjusting MMT for GQL-85 #1319

Closed
wants to merge 5 commits into from
Closed

MMT-3944: Adjusting MMT for GQL-85 #1319

wants to merge 5 commits into from

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

This is the react side fix needed to complete GQL-85: Cannot view collection metadata C1000000321-SEDAC in MMT "All Collections"

What is the Solution?

Added 'deleted' to all concepts and edited RevisionList so that the table reflects when a revision is no longer available.

What areas of the application does this impact?

RevisionList and all concept GQL calls

Testing

Reproduction steps

  • **Environment for testing: UAT
  • **Collection to test with: URLs provided below
  1. run cmr-graphql in UAT mode on branch GQL-85
  2. For collection, see http://localhost:5173/collections/C1271740211-OB_CLDSIT/revisions and compare with what's currently in UAT: https://mmt.uat.earthdata.nasa.gov/collections/C1271740212-OB_CLDSIT
  3. For Variable, see http://localhost:5173/variables/V1256589611-MMT_2/revisions and compare with what's currently in UAT: https://mmt.uat.earthdata.nasa.gov/variables/V1256589611-MMT_2/revisions
  4. For Tool: still looking...
  5. For Service: still looking...

Attachments

Screenshot 2024-11-07 at 1 51 22 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@mandyparson mandyparson requested review from cgokey and htranho November 8, 2024 16:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.63%. Comparing base (d7ea081) to head (bf57524).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ic/src/js/components/RevisionList/RevisionList.jsx 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   97.68%   97.63%   -0.05%     
==========================================
  Files         366      366              
  Lines        5743     5752       +9     
  Branches     1205     1208       +3     
==========================================
+ Hits         5610     5616       +6     
- Misses        132      135       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandyparson
Copy link
Contributor Author

Closed as OBE. Will continue to come up with a solution for this issue in another ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants