MMT-3943: Updated to support times in UTC #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 366 366
Lines 5743 5753 +10
Branches 1205 1208 +3
=======================================
+ Hits 5610 5620 +10
Misses 132 132
Partials 1 1 ☔ View full report in Codecov by Sentry. |
htranho
approved these changes
Nov 22, 2024
added 4 commits
November 22, 2024 16:27
…t with ms. It is also now consistent with the placeholder text.
|
When I change the time to this: 2024-11-25T23:59:59.999Z and click "save and continue" then come back, it changes the time to 2024-11-25T16:59:59.000Z |
mandyparson
approved these changes
Nov 25, 2024
…that a revision has been deleted (#1323) * MMT-3946: Making UI for deleted Rows * MMT-3946: Adding Comments
…t with ms. It is also now consistent with the placeholder text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
The existing date/time widget would wipe out any time the user selected. We should allow them to select a time or type in the time and preserve what they type.
What is the Solution?
The widget now configures the react-date-picker to show times. Also if they select a time, it should display in ISO format. Both the time picker and the text field should show the date in UTC.
What areas of the application does this impact?
Any forms that use the date time picker (such as Temporal Information page)
Testing
Go to the Temporal Information page and add a Single Date Time. Click on the text field, this will bring up the widget.
You'll see the ability to select times on the right.
You can also type in the time in the text box.
Verify that either what you select or type show up in the JSON below.
Attachments
Checklist