Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3926: Fix for Science Keyword Picker Adds An Additional Science Keyword That Was Not Originally Selected #1324

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

cgokey
Copy link
Collaborator

@cgokey cgokey commented Nov 25, 2024

Overview

What is the feature?

Science Keyword Picker Adds An Additional Science Keyword That Was Not Originally Selected

What is the Solution?

In the onChange event, check if the text to search is empty, if so, ignore the search.

What areas of the application does this impact?

Science Keyword Picker

Testing

Here are the steps to reproduce (video demonstration is also attached).
Navigate to a collection > Descriptive Keywords
Search for a keyword using the keyword widget
Add a keyword
Click x in the search picker
EARTH SCIENCE > AGRICULTURE > AGRICULTURAL AQUATIC SCIENCES > AQUACULTURE is added by mistake (note: this is the 1st keyword in the keyword pick list.)

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (53c2a92) to head (789bdbf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
- Coverage   97.68%   97.68%   -0.01%     
==========================================
  Files         366      366              
  Lines        5757     5753       -4     
  Branches     1199     1208       +9     
==========================================
- Hits         5624     5620       -4     
  Misses        132      132              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgokey cgokey merged commit 94ad25e into main Dec 9, 2024
5 of 7 checks passed
@cgokey cgokey deleted the MMT-3926 branch December 9, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants