MMT-3923: Catch intermittent error from EDL #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 366 366
Lines 5757 5757
Branches 1199 1211 +12
=======================================
Hits 5624 5624
Misses 132 132
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Is there no way to reproduce this locally? For testing, all I see is 'see test session' |
It is about intermittent failing of EDL in production. Couldn't verify this issue on SIT or UAT and also in local mmt instance. |
mandyparson
approved these changes
Dec 10, 2024
cgokey
reviewed
Dec 12, 2024
| @@ -17,9 +17,18 @@ class ErrorBoundary extends React.Component { | |||
| } | |||
|
|
|||
| static getDerivedStateFromError(error) { | |||
| let errorMessage = error.message | |||
There was a problem hiding this comment.
You should add a test that mocks this response
There was a problem hiding this comment.
Added in ErrorBoundary.test.js
cgokey
requested changes
Dec 12, 2024
cgokey
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
cmr-graphql returns intermittent error getting acl and groups from EDL.
What is the Solution?
Catch that error and create banner message to refresh browser.
What areas of the application does this impact?
View of single Permission
Testing
See test session.
Attachments
N/A
Checklist