-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve test coverage for dimension cleanup #248
Merged
danielfromearth
merged 11 commits into
release/1.6.0
from
feature/issue-237-improve-test-coverage-further-particularly-for-dimension_cleanup
Nov 19, 2024
Merged
improve test coverage for dimension cleanup #248
danielfromearth
merged 11 commits into
release/1.6.0
from
feature/issue-237-improve-test-coverage-further-particularly-for-dimension_cleanup
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfromearth
changed the title
temporary, work in progress commit
improve test coverage for dimension cleanup
Nov 15, 2024
…urther-particularly-for-dimension_cleanup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.6.0 #248 +/- ##
================================================
Coverage ? 88.11%
================================================
Files ? 11
Lines ? 648
Branches ? 0
================================================
Hits ? 571
Misses ? 77
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…rage-further-particularly-for-dimension_cleanup
…larly-for-dimension_cleanup' of https://github.com/nasa/stitchee into feature/issue-237-improve-test-coverage-further-particularly-for-dimension_cleanup
danielfromearth
deleted the
feature/issue-237-improve-test-coverage-further-particularly-for-dimension_cleanup
branch
November 19, 2024 18:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #237
Description
Improved test coverage, though dimension cleanup still has the main duplicate dimension function not covered. It needs further work, or to be removed following the implementation of using DataTree (as in issue #138).
PR Acceptance Checklist
CHANGELOG.md
updated📚 Documentation preview 📚: https://stitchee--248.org.readthedocs.build/en/248/