Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test coverage for dimension cleanup #248

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Nov 15, 2024

GitHub Issue: #237

Description

Improved test coverage, though dimension cleanup still has the main duplicate dimension function not covered. It needs further work, or to be removed following the implementation of using DataTree (as in issue #138).

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://stitchee--248.org.readthedocs.build/en/248/

@danielfromearth danielfromearth changed the title temporary, work in progress commit improve test coverage for dimension cleanup Nov 15, 2024
stitchee bot and others added 2 commits November 15, 2024 19:35
@danielfromearth danielfromearth marked this pull request as ready for review November 19, 2024 15:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/1.6.0@2e38bb3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
concatenator/dimension_cleanup.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/1.6.0     #248   +/-   ##
================================================
  Coverage                 ?   88.11%           
================================================
  Files                    ?       11           
  Lines                    ?      648           
  Branches                 ?        0           
================================================
  Hits                     ?      571           
  Misses                   ?       77           
  Partials                 ?        0           
Flag Coverage Δ
integration 44.90% <0.00%> (?)
unittests 85.64% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@danielfromearth danielfromearth marked this pull request as draft November 19, 2024 16:41
@danielfromearth danielfromearth marked this pull request as ready for review November 19, 2024 18:32
@danielfromearth danielfromearth changed the base branch from develop to release/1.6.0 November 19, 2024 18:35
danielfromearth and others added 4 commits November 19, 2024 13:35
…rage-further-particularly-for-dimension_cleanup
…larly-for-dimension_cleanup' of https://github.com/nasa/stitchee into feature/issue-237-improve-test-coverage-further-particularly-for-dimension_cleanup
@danielfromearth danielfromearth self-assigned this Nov 19, 2024
@danielfromearth danielfromearth merged commit 106edb9 into release/1.6.0 Nov 19, 2024
4 checks passed
@danielfromearth danielfromearth deleted the feature/issue-237-improve-test-coverage-further-particularly-for-dimension_cleanup branch November 19, 2024 18:51
@danielfromearth danielfromearth mentioned this pull request Nov 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage further, particularly for dimension_cleanup
2 participants