Remove status attribute requirement when state is present

[Dav-C]

Closes #251

Remove the status field requirement when state is present. This should eliminate the need to provide a status when updating non-status fields on an existing record.

[whitej6]

Thoughts on validating when self.nb_object is empty and status in arg spec but was not provided, the raising an error instead of relying on a traceback from pynautobot.

[joewesch]

You missed one in the device_interface module.

[Dav-C]

Thoughts on validating when self.nb_object is empty and status in arg spec but was not provided, the raising an error instead of relying on a traceback from pynautobot.

If I understand correctly, this would mean updating this check for all required fields not just status. With the change in this PR, if you attempt to create a record without a required status field this is the result, which I think is pretty clear.

TASK [Create a Nautobot Rack] ******************************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "{\"status\":[\"This field is required.\"]}"}

[joewesch]

Honestly, looking at the code closer I think we should remove every required_if all together. None of the parameters are truly required on updates that aren't set as required=True in the argspec - which just makes the required_if redundant.

[Dav-C]

Honestly, looking at the code closer I think we should remove every required_if all together. None of the parameters are truly required on updates that aren't set as required=True in the argspec - which just makes the required_if redundant.

I agree that it makes sense to remove it in most cases. There are some I'm not so sure about, however. Locations for example require an id if the state is absent, which I assume is to prevent deleting multiple locations with the same name.

[joewesch]

Honestly, looking at the code closer I think we should remove every required_if all together. None of the parameters are truly required on updates that aren't set as required=True in the argspec - which just makes the required_if redundant.

I agree that it makes sense to remove it in most cases. There are some I'm not so sure about, however. Locations for example require an id if the state is absent, which I assume is to prevent deleting multiple locations with the same name.

Good catch, yes.

[joewesch]

I guess I should have clarified, I don't think we need any required_if on present states.

[Dav-C]

PR updated to remove all references to required_if state is present

[whitej6]

Thoughts on validating when self.nb_object is empty and status in arg spec but was not provided, the raising an error instead of relying on a traceback from pynautobot.

If I understand correctly, this would mean updating this check for all required fields not just status. With the change in this PR, if you attempt to create a record without a required status field this is the result, which I think is pretty clear.

TASK [Create a Nautobot Rack] ******************************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "{\"status\":[\"This field is required.\"]}"}

Looks good to me, I thought possibly it would be a python traceback. The message provided is good. :-)

[joewesch]

Looks great, thank you!