Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staker] added logic to reload wallet if unloaded while staker is active #159

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

mxaddict
Copy link
Collaborator

@mxaddict mxaddict commented Jul 31, 2024

No description provided.

@mxaddict mxaddict force-pushed the navio-staker-crash-wallet-unload branch from 4b406ec to 9c57e56 Compare August 1, 2024 15:09
@mxaddict mxaddict changed the title Added error message for when the staker fails to load stake commitments Added logic to reload wallet if unloaded while staker is active Aug 2, 2024
@mxaddict mxaddict force-pushed the navio-staker-crash-wallet-unload branch from 9c57e56 to 40c8e73 Compare August 2, 2024 17:15
@mxaddict mxaddict changed the title Added logic to reload wallet if unloaded while staker is active [staker] added logic to reload wallet if unloaded while staker is active Aug 4, 2024
@aguycalled
Copy link
Collaborator

I think it would be better if the RPC error from the calls (ideally implemented in CallRPC - similar to what ParseError does) is parsed and acts accordingly, since the exception can happen for other reasons different to the wallet being unloaded.

@mxaddict
Copy link
Collaborator Author

mxaddict commented Aug 9, 2024 via email

@mxaddict mxaddict force-pushed the navio-staker-crash-wallet-unload branch from 40c8e73 to cc48ad3 Compare August 10, 2024 08:11
@mxaddict mxaddict force-pushed the navio-staker-crash-wallet-unload branch from b82a21c to c32ca07 Compare August 10, 2024 11:38
@aguycalled aguycalled merged commit 05a19d2 into nav-io:master Aug 11, 2024
6 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants