Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Re-generate using the latest flex #357

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ing-eoking
Copy link
Collaborator

@ing-eoking ing-eoking commented Feb 5, 2025

πŸ”— Related Issue

  • jam2in/arcus-works#461
  • ν˜„μž¬ MacOSμ—μ„œ C Clientλ₯Ό λΉŒλ“œν•  λ•Œ μ•„λž˜μ™€ 같은 μ—λŸ¬κ°€ λ°œμƒν•©λ‹ˆλ‹€.
libmemcached/csl/scanner.cc:1454:2: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
        register yy_state_type yy_current_state;
  • μ΄λŠ” C/C++의 ν‚€μ›Œλ“œ 쀑 ν•˜λ‚˜μΈ registerκ°€ C++17 μ΄ν›„λ‘œ μ™„μ „νžˆ μ œκ±°λ˜μ—ˆκΈ° λ•Œλ¬Έμ— λ°œμƒν•œ μ—λŸ¬μž…λ‹ˆλ‹€.
  • scanner.h/ccλ₯Ό μƒμ„±ν•˜λŠ” 데 μ‚¬μš©ν•œ flex 버전은 2.5.35μ˜€κ³ , μ΅œμ‹  λ²„μ „μ˜ flexλ₯Ό μ‚¬μš©ν•˜μ—¬ μƒμ„±ν•œ scanner.h/ccμ—μ„œλŠ” register ν‚€μ›Œλ“œκ°€ 더 이상 ν¬ν•¨λ˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

⌨️ What I did

  • INTERNAL: Modify some code in the parserΒ #355 와 λ§ˆμ°¬κ°€μ§€λ‘œ 기쑴의 scanner.h/cc와 scanner.l 간에 토큰 이름에 차이가 μžˆμ–΄ 이λ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
    • TRUE β†’ MC_TRUE
  • μ΅œμ‹  릴리슀된 flex 2.6.4λ₯Ό μ‚¬μš©ν•˜μ—¬ scanner.h/ccλ₯Ό λ‹€μ‹œ μƒμ„±ν–ˆμŠ΅λ‹ˆλ‹€.
  • scanner.h/cc μ½”λ“œ μžμ²΄λŠ” μƒμ„±λ§Œ ν–ˆκ³ , λ”°λ‘œ μˆ˜μ •ν•œ 사항은 μ—†μŠ΅λ‹ˆλ‹€

@jhpark816 jhpark816 requested a review from namsic February 5, 2025 03:15
@jhpark816 jhpark816 merged commit 7a40cd8 into naver:develop Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants