Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNAL: Set MEMCACHED_MAX_KEY to the key length, not the memory size #358

Closed
wants to merge 1 commit into from
Closed

INTERNAL: Set MEMCACHED_MAX_KEY to the key length, not the memory size #358

wants to merge 1 commit into from

Conversation

ing-eoking
Copy link
Collaborator

🔗 Related Issue

⌨️ What I did

  • MEMCACHED_MAX_KEY 에서 NULL 문자를 제외하고, 오직 MAX_KEY 길이정보만 갖도록 변경합니다.
    • 4001 -> 4000

@ing-eoking ing-eoking marked this pull request as draft February 7, 2025 07:55
@ing-eoking ing-eoking marked this pull request as ready for review February 12, 2025 05:27
@jhpark816
Copy link
Contributor

@ing-eoking 리뷰할 수 있는 PR인가요?

@ing-eoking
Copy link
Collaborator Author

@jhpark816
네. 리뷰해주시면 될 것 같습니다.

@jhpark816
Copy link
Contributor

@ing-eoking
MEMCACHED_MAX_KEY는 아래 의미를 가져야 하므로, 기존 코드를 그대로 유지하겠습니다.

       MEMCACHED_MAX_KEY
              Default maximum size of a key (which includes the null pointer).
              Master keys have no limit, this only applies to keys used for
              storage.

@jhpark816 jhpark816 closed this Feb 12, 2025
@ing-eoking ing-eoking deleted the maxkey branch February 12, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ing-eoking @jhpark816