TEST: Feat not piped test #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheesecrust
force-pushed
the
test/notpiped
branch
from
b0784d8 to
e244afe
Compare
oliviarla
reviewed
Dec 5, 2024
| errorList = future.get(5000L, | ||
| TimeUnit.MILLISECONDS); | ||
| assertEquals(1, errorList.size()); | ||
| } catch (TimeoutException e) { |
There was a problem hiding this comment.
전체적으로 timeout exception은 catch하지 않아도 될 것 같습니다.
| try { | ||
| // UPDATE | ||
| future = mc.asyncBopPipedUpdateBulk(KEY, updateElements); | ||
| errorList = future.get(5000L, |
There was a problem hiding this comment.
개행이 필요 없을 것 같습니다. 전체적으로 확인해주세요.
cheesecrust
force-pushed
the
test/notpiped
branch
from
e244afe to
195afa2
Compare
oliviarla
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
CollectionBulkInsertOperationImpl은asyncBopInsertBulk,CollectionPipedInsertOperationImpl은asyncSopPipedInsertBulk,CollectionPipedUpdateOperationImpl은asyncBopPipedUpdateBulk각각 위에 연산에 대하여 위 연산들을 실행하는 테스트 파일에 테스트를 추가한다.
시나리오는 아이템을 하나씩만 주어 파이프와 벌크 연산의 handleLine 에서 isNotPiped()를 테스트한다.
이때 연산이 성공하는 경우와 연산이 실패하는 경우를 모두 다룬다.