CLEANUP: Refactor cmdlog include #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Oct 24, 2024
| @@ -26,9 +28,8 @@ | |||
| #include <unistd.h> | |||
| #include <assert.h> | |||
| #include <errno.h> | |||
There was a problem hiding this comment.
@cheesecrust
๊ธฐ์กด include์์ ์ ์ธํ ์ ์๋ ๊ฒ์ ํ์ธํด ์ฃผ์ธ์.
There was a problem hiding this comment.
stdint, stdbool, unistd์ ์๋ฃํ์ด๋ ๋ฉ์๋๋ ์ฐ์ด์ง๋ง cmdlog.c ์์ include ํ๋ ํค๋ํ์ผ์์ ์ด๋ฏธ include ํ๊ณ ์์ด์ ์ ๊ฑฐํ์์ต๋๋ค.
cheesecrust
force-pushed
the
cleanup/cmdlog
branch
2 times, most recently
from
1b22b0f to
bfc3b4c
Compare
namsic
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
โจ๏ธ What I did
cmdlog.h์ ์์น๋ฅผmemcached.h์์memcached.c๋ก ์ฎ๊น