Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Extend bkey/eflag max length #816

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

namsic
Copy link
Collaborator

@namsic namsic commented Jan 8, 2025

πŸ”— Related Issue

  • jam2in/arcus-works#632

⌨️ What I did

  • MAX_BKEY_LENG, MAX_EFLAG_LENG 값을 μ¦κ°€μ‹œν‚΅λ‹ˆλ‹€. (31 => 63)

@jhpark816 jhpark816 requested a review from ing-eoking January 8, 2025 05:28
@jhpark816
Copy link
Collaborator

jhpark816 commented Jan 8, 2025

@ing-eoking
MAX_BKEY_LENG, MAX_EFLAG_LENG 값을 μ¦κ°€μ‹œμΌ°μ„ λ–„, κΈ°μ‘΄ κ΅¬ν˜„μ— λ¬Έμ œκ°€ 될 λ§Œν•œ 뢀뢄이 μžˆλŠ” 지λ₯Ό 리뷰 λ°”λžλ‹ˆλ‹€.

@namsic namsic force-pushed the extend_bkey_eflag branch from cebf4c4 to 15bff54 Compare January 8, 2025 05:39
@namsic
Copy link
Collaborator Author

namsic commented Jan 8, 2025

  • λ¬Έμ„œ μˆ˜μ •μ΄ λˆ„λ½λœ 뢀뢄이 μžˆμ–΄ μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

  • PR 반영되고 λ‚˜λ©΄, EEμ—μ„œλŠ” μ•„λž˜ μ£Όμ„λ§Œ μˆ˜μ •ν•˜λ©΄ 될 κ²ƒμœΌλ‘œ λ³΄μž…λ‹ˆλ‹€.

struct cset_item_btree_unlink_noref {
  uint16_t  length;
  uint8_t   type;
  uint8_t   flags;
  hash_item *it; /* btree item */
  uint8_t   nbkey; /* 0 = 8B... */
  /* char bkey[MAX_BKEY_LENG];
   * MAX_BKEY_LENG = 31, defined in types.h.
   * The actual size of this item is sizeof(struct ...), rounded up to the
   * nearest multiple of 4.
   */
};

Copy link
Collaborator

@ing-eoking ing-eoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LQ Detect의 LQ_QUERY_SIZEλ₯Ό λŠ˜λ €μ•Ό ν•  것 κ°™μŠ΅λ‹ˆλ‹€.

#define LQ_QUERY_SIZE  (64*2+64)

// <longest bkey>..<longest bkey> efilter <offset> <count> delete

@namsic namsic force-pushed the extend_bkey_eflag branch from 15bff54 to b8df7eb Compare January 8, 2025 10:32
Copy link
Collaborator

@ing-eoking ing-eoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Persistence μͺ½ λ¬Έμžμ—΄ 버퍼 크기 μͺ½λ„ μˆ˜μ •ν•΄μ•Ό ν•  것 κ°™μŠ΅λ‹ˆλ‹€.

@namsic namsic force-pushed the extend_bkey_eflag branch from b8df7eb to e7c099e Compare January 10, 2025 02:26
@namsic namsic force-pushed the extend_bkey_eflag branch from e7c099e to 3d68197 Compare January 10, 2025 02:38
@ing-eoking ing-eoking requested a review from jhpark816 January 10, 2025 03:12
@namsic
Copy link
Collaborator Author

namsic commented Jan 13, 2025

ν˜„μž¬ κ΅¬ν˜„ κΈ°μ€€ EE λ²„μ „μ—μ„œ λ¬Έμ œκ°€ 생길 μ†Œμ§€κ°€ μžˆμœΌλ―€λ‘œ ν˜„μž¬ PR λ°˜μ˜μ€ 보λ₯˜ν•©λ‹ˆλ‹€. (이슈 μ½”λ©˜νŠΈ μ°Έκ³ )

@namsic namsic marked this pull request as draft January 13, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants