-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTERNAL: Extend bkey/eflag max length #816
base: develop
Are you sure you want to change the base?
Conversation
@ing-eoking |
cebf4c4
to
15bff54
Compare
struct cset_item_btree_unlink_noref {
uint16_t length;
uint8_t type;
uint8_t flags;
hash_item *it; /* btree item */
uint8_t nbkey; /* 0 = 8B... */
/* char bkey[MAX_BKEY_LENG];
* MAX_BKEY_LENG = 31, defined in types.h.
* The actual size of this item is sizeof(struct ...), rounded up to the
* nearest multiple of 4.
*/
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LQ Detectμ LQ_QUERY_SIZE
λ₯Ό λλ €μΌ ν κ² κ°μ΅λλ€.
#define LQ_QUERY_SIZE (64*2+64)
// <longest bkey>..<longest bkey> efilter <offset> <count> delete
15bff54
to
b8df7eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Persistence μͺ½ λ¬Έμμ΄ λ²νΌ ν¬κΈ° μͺ½λ μμ ν΄μΌ ν κ² κ°μ΅λλ€.
arcus-memcached/engines/default/cmdlogrec.c
Lines 1045 to 1046 in 447601d
char bkeystr[90]; char eflagstr[90]; arcus-memcached/engines/default/cmdlogrec.c
Line 1113 in 447601d
char bkeystr[90]; arcus-memcached/engines/default/cmdlogrec.c
Lines 1045 to 1046 in 447601d
char bkeystr[90]; char eflagstr[90]; arcus-memcached/engines/default/cmdlogrec.c
Lines 1213 to 1214 in 447601d
char fbkeystr[90]; char tbkeystr[90];
b8df7eb
to
e7c099e
Compare
e7c099e
to
3d68197
Compare
νμ¬ κ΅¬ν κΈ°μ€ EE λ²μ μμ λ¬Έμ κ° μκΈΈ μμ§κ° μμΌλ―λ‘ νμ¬ PR λ°μμ 보λ₯ν©λλ€. (μ΄μ μ½λ©νΈ μ°Έκ³ ) |
π Related Issue
β¨οΈ What I did
MAX_BKEY_LENG
,MAX_EFLAG_LENG
κ°μ μ¦κ°μν΅λλ€. (31 => 63)