Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will wrap these before the next release.
These should be easy:
sqlite3_db_cacheflush
sqlite3_db_status
sqlite3_value_frombind
sqlite3_table_column_metadata
sqlite3_trace_v2
raises interesting questions. It'd be a second "constructor" for*sqlite3.Stmt
, which raises the question of pointer identity. If we want two*sqlite3.Stmt
to be equal, we need to dedup them, which means storing a list of them in*sqlite3.Conn
(which incidentally SQLite also does). We'd also probably need identity, to make it easier to trace the start/row/end moments of a*sqlite3.Stmt
run.If we do this, we can also iterate over statements in a connection (replacing
sqlite3_next_stmt
), andsqlite3_sql
andsqlite3_expanded_sql
can also start to make sense.These are also done:
sqlite3_sql
sqlite3_expanded_sql
sqlite3_next_stmt
sqlite3_trace_v2