Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QPS and Burst overrides #291

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

craig-willis
Copy link
Collaborator

Fixes #289

This adds the QPS and Burst configuration overrides for the kube client. I've set defaults at 50/100, which works for the CHEESEHub case.

To test:

Copy link
Member

@bodom0015 bodom0015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test worked well, although my dev system was a bit too small for 30 users. I may need to retest against production after merging.

Minor notes/feedback:

  • We may want to add a note/reminder in the docs about updating the host variable in the postman template, as I may have accidentally run some containers on cheesehub prod while trying to test against my dev instance
  • "Clean up containers" instructions says 20 instead of 30
  • If possible, it might be helpful to parameterize the number of instances (eventually - not required as a part of this PR)

@craig-willis craig-willis merged commit 02a14a6 into nds-org:develop Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants