Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Turn off RocksDB build extras. #44

Closed
wants to merge 1 commit into from

Conversation

l-laura
Copy link
Contributor

@l-laura l-laura commented Nov 13, 2023

Turned off a bunch of CMake flags that are activated by default in RocksDB CMakeLists.

Test

Check if / how much this improves the build time.

Current main (included here): 35m 59s.
Conan-introducing branch with multi-threaded build (not included, could complement these changes): 14m 20s.

Copy link

Package Line Rate Branch Rate Health
libs.http-datasource.src 81% 41%
libs.http-service.src 80% 42%
libs.logging.include.mapget 100% 0%
libs.model.include.mapget.model 81% 41%
libs.model.src 87% 49%
libs.service.include.mapget.service 100% 0%
libs.service.src 82% 45%
Summary 84% (1647 / 1960) 46% (1594 / 3465)

Minimum allowed line rate is 50%

@johannes-wolf
Copy link
Contributor

johannes-wolf commented Nov 14, 2023

@l-laura Please take a look at my PR #41 which improves build-time to ~15 min. The current CI build on one core only. ;)
Not ready yet, but maybe you can rebase on that branch? I will also take a look if we could create a PR on the conan-io repository for never RocksDB packages…

@l-laura
Copy link
Contributor Author

l-laura commented Nov 16, 2023

The changes didn't seem to have much effect, so let's drop this and go with Johannes' approach :)

@l-laura l-laura closed this Nov 16, 2023
@MisterGC MisterGC deleted the improvement/disable-rocksdb-extras branch December 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants