Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2024.4 #78

Merged
merged 27 commits into from
Sep 25, 2024
Merged

Version 2024.4 #78

merged 27 commits into from
Sep 25, 2024

Conversation

josephbirkner
Copy link
Contributor

These new endpoints facilitate the Datasource Editor GUI in erdblick.

johannes-wolf
johannes-wolf reviewed Aug 28, 2024
View reviewed changes
libs/http-service/src/http-service.cpp Outdated Show resolved Hide resolved
test/unit/utility.cpp Show resolved Hide resolved
josephbirkner and others added 2 commits September 4, 2024 14:17
@josephbirkner
Bump simfil to v0.3.2
1290ab6
@Waguramu
* Add functionality for processing
fc7a061 
* Add hash function
* Add cli command
* Add default schema
@Waguramu Waguramu self-assigned this Sep 9, 2024
@Waguramu
* Add json-schema-validator library
56118c4 
* Supply default_config_schema.json
@Waguramu Waguramu mentioned this pull request Sep 10, 2024
Merged
@Waguramu
Copy link
Contributor

Waguramu commented Sep 10, 2024 •
edited
Loading

TODOs:

  • Only update http-settings and sources.
  • Fix http-sources tests.
  • Refactor (factor out) converter functions from the HTTP methods.

@Waguramu Waguramu marked this pull request as ready for review September 10, 2024 13:41
@Waguramu Waguramu mentioned this pull request Sep 10, 2024
Merged
Waguramu and others added 15 commits September 10, 2024 17:59
@josephbirkner josephbirkner changed the title Added new GET/POST config endpoints Version 2024.4 Sep 19, 2024
MisterGC
MisterGC reviewed Sep 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
MisterGC
MisterGC previously requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@MisterGC MisterGC left a comment •
edited by josephbirkner
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Clarify missing patch version

CMakeLists.txt Outdated Show resolved Hide resolved
conanfile.py Show resolved Hide resolved
libs/service/src/config.cpp Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
29 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Package Line Rate Branch Rate Health
libs.http-datasource.src 57% 31% ➖
libs.http-service.src 64% 35% ➖
libs.logging.include.mapget 71% 33% ➖
libs.model.include.mapget.model 53% 31% ➖
libs.model.src 60% 36% ➖
libs.service.include.mapget.service 67% 0% ➖
libs.service.src 75% 43% ➖
Summary 63% (3002 / 4776) 36% (2846 / 7809) ➖

Minimum allowed line rate is 50%

@josephbirkner josephbirkner merged commit f5507b2 into main Sep 25, 2024
14 checks passed
@josephbirkner josephbirkner deleted the config-endpoint branch September 25, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannes-wolf johannes-wolf johannes-wolf left review comments

@Waguramu Waguramu Waguramu approved these changes

@MisterGC MisterGC Awaiting requested review from MisterGC

Assignees

@Waguramu Waguramu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephbirkner @Waguramu @johannes-wolf @MisterGC