Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use near-workspaces for the tests during the CI process #1211

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

gtsonevv
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Sometimes the CI node (https://rpc.ci-testnet.near.org/) does not respond to status requests causing all test that rely on it to fail. By moving to near-workspaces, the tests will be smoother and less likely to have problems. This transition aligns with best practices in test environment management and ensures that the CI process remains reliable and efficient.

Test Plan

All existing tests are passing.

Related issues/PRs

@gtsonevv gtsonevv requested a review from frol November 30, 2023 09:41
Copy link

changeset-bot bot commented Nov 30, 2023

⚠️ No Changeset found

Latest commit: df0cd87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gtsonevv gtsonevv requested a review from gagdiez December 12, 2023 09:47
vikinatora
vikinatora previously approved these changes Jan 3, 2024
Copy link
Collaborator

@vikinatora vikinatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conficts have to be resolved, other than that looks good.

@gtsonevv gtsonevv requested a review from vikinatora January 22, 2024 12:44
@gtsonevv gtsonevv merged commit ab4f8d3 into near:master Jan 22, 2024
1 check passed
@gtsonevv gtsonevv deleted the near-workspaces-integration branch January 22, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants