-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fastnear
as an alternative provider of NEAR blockchain data
#109
Conversation
fastnear
as an alternative provider of NEAR blockchain data
@race-of-sloths please, include my PR in the Race |
@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 13! @khorolets received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR that bring a great value to the users and contributes into a decentralization. Great job!
The only thing that is left is around the README, we need to add a section describing that now there is a couple of data providers the framework supports and clearly explain how to use both of them.
Also, we need to add the paragraph about the migration from the previous version even though it's a matter of adding .into()
.
After that we'll be more ready for merging except for the blocker we have (using the nearcore fork for the near-indexer-primitives crate)
9471995
to
b7291e0
Compare
@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: waiting for scoringWe're waiting for maintainer to score this pull request with What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
d1e0d8c
to
f32afc3
Compare
f32afc3
to
a010067
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had another closer look on the implementation. Still have some doubts, but don't have any objections. Overall the providers feature is well done.
Breaking changes are described in the CHANGELOG, and are related to more advanced usage of the framework rather than average. I think we're good to go releasing it.
We need to check if we're still blocked on the primitives and I requested to provide a link to FastNear's NearData repo in the docs.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths score 13
This PR introduces
fastnear
as an alternative data provider to theNEAR Lake Framework
. By integratingfastnear
, we aim to provide a more flexible source for retrieving NEAR blockchain data, enhancing the overall versatility and performance of the framework.Changes
fastnear
as an additional data source.fastnear
.NEAR Lake
andfastnear
providers based on user preference or use case.Motivation
Adding
fastnear
as a source allows users to access NEAR blockchain data from a different provider, potentially benefiting from performance or cost improvements.