-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(0.7.x): 0.7.5 with exposed non-retryable s3_fetchers #98
Conversation
cc @kobayurii |
LGTM! Thank you a lot! |
|
||
[dependencies] | ||
anyhow = "1.0.51" | ||
aws-config = { version = "1.0.0", features = ["behavior-version-latest"] } | ||
aws-types = "1.0.0" | ||
aws-credential-types = "1.0.0" | ||
aws-sdk-s3 = "0.39.1" | ||
aws-smithy-types = "1.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to move it from dev-dependencies to a general one since I introduced a variant with aws-smithy-types
error to LakeError
regarding the byte-stream
.await? | ||
.body | ||
.collect() | ||
.await? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one will convert into new LakeError::AwsSmithyError
src/types.rs
Outdated
IntConversionError { | ||
#[from] | ||
error: std::num::TryFromIntError, | ||
}, | ||
#[error("AWS Smithy byte_stream error: {error}")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[error("AWS Smithy byte_stream error: {error}")] | |
#[error("AWS Smithy byte_stream error: {error:?}")] |
Can we print the debug message, the normal display message doesn't provide much information. Same for AwsError
too please 🙏🏼
This PR should address #97 and bump the version of the crate to 0.7.5
I had to extract the code from the infinity loops of
fetch_block_or_retry
and a similar function for the shards.I made two new functions:
fetch_block
andfetch_shard
, and made them public.