Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CI to frontend (lint ,test, typecheck, build) #799

Merged
merged 7 commits into from
Jun 14, 2024
Merged

feat: add CI to frontend (lint ,test, typecheck, build) #799

merged 7 commits into from
Jun 14, 2024

Conversation

Kevin101Zhang
Copy link
Contributor

@Kevin101Zhang Kevin101Zhang commented Jun 12, 2024 •
edited
Loading

Added CI.yml for lint, Test, typecheck, build,
Other files are linted with ts-config, prettier, and eslintrc.
manually Removed dead files.

@Kevin101Zhang Kevin101Zhang linked an issue Jun 12, 2024 that may be closed by this pull request
Create FE CI #788
Closed
@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review June 12, 2024 21:41
@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner June 12, 2024 21:41
@Kevin101Zhang Kevin101Zhang changed the title added frontend-ci.yml add CI to frontend Jun 12, 2024
darunrs
darunrs approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a scan through the changes, but its naturally tough to parse with all the syntax updates. I didn't see anything problematic. As long as the CI works, and we check dev to ensure all features work, this should be good!

@Kevin101Zhang Kevin101Zhang merged commit 5462ec5 into main Jun 14, 2024
4 checks passed
@Kevin101Zhang Kevin101Zhang deleted the 788-create-fe-ci branch June 14, 2024 17:31
@Kevin101Zhang Kevin101Zhang changed the title add CI to frontend add CI to frontend (lint ,test, typecheck, build) Jun 14, 2024
@morgsmccauley morgsmccauley mentioned this pull request Jun 18, 2024
Merged
@Kevin101Zhang Kevin101Zhang changed the title add CI to frontend (lint ,test, typecheck, build) feat: add CI to frontend (lint ,test, typecheck, build) Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darunrs darunrs darunrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create FE CI
2 participants
@Kevin101Zhang @darunrs