Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display the number of queries in the past 7 days on each indexer card in the dashboard #837

Conversation

Kevin101Zhang
Copy link
Contributor

@Kevin101Zhang Kevin101Zhang commented Jun 25, 2024

BOS component indexercard now queries past 7 day query count.

@Kevin101Zhang Kevin101Zhang changed the base branch from main to 759-remember-line-position-of-indexerlogic-and-schema-when-moving-between-them-and-the-status-tab June 25, 2024 20:46
@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review June 25, 2024 20:49
@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner June 25, 2024 20:49
@Kevin101Zhang
Copy link
Contributor Author

Screenshot 2024-06-25 at 4 49 05 PM

const sanitizedIndexerName = indexerName.replaceAll(".", "_");
const sanitizedAccountName = accountId.replaceAll(".", "_");
const fullFunctionName = sanitizedAccountName + "_" + sanitizedIndexerName;
const tableName = `${fullFunctionName}_sys_logs_aggregate`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should using the file @eduohe has created?

Base automatically changed from 759-remember-line-position-of-indexerlogic-and-schema-when-moving-between-them-and-the-status-tab to main July 2, 2024 19:18
eduohe
eduohe previously requested changes Jul 12, 2024
@@ -1,11 +1,9 @@
const accountId = props.accountId || context.accountId;
const indexerName = props.indexerName;
const { accountId, indexerName, lastDeploymentDate, numDeployements, numQueries, originalDeploymentDate } = props;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to show originalDeploymentDate in the card too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive this is more for internal use. Clarified with pavel

@Kevin101Zhang Kevin101Zhang dismissed eduohe’s stale review July 15, 2024 22:11

Clarified usecase with pavel

@Kevin101Zhang Kevin101Zhang merged commit 1a2d419 into main Jul 15, 2024
4 checks passed
@Kevin101Zhang Kevin101Zhang deleted the 795-display-the-number-of-queries-in-the-past-7-days-on-each-indexer-card-in-the-dashboard branch July 15, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the number of queries in the past 7 days on each indexer card in the dashboard
3 participants