Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query.function_call ReadRPC returns error while NEAR RPC succeeds #139

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

kobayurii
Copy link
Member

@kobayurii kobayurii commented Nov 27, 2023

This pull request encompasses several crucial updates and resolves specific issues.

  1. update dependencies
  2. up rust version
  3. query.function_call ReadRPC returns error while NEAR RPC succeeds

Fixed an issue with the query.function_call ReadRPC call that used to inconsistently return errors while NEAR RPC was successful. This was because a version of nearcore less than 1.35 did not support running contracts built on rust 1.70+.

@kobayurii kobayurii force-pushed the func_call branch 2 times, most recently from 2462588 to 1459d18 Compare November 28, 2023 08:46
@kobayurii kobayurii requested a review from khorolets November 28, 2023 08:58
@kobayurii kobayurii marked this pull request as ready for review November 28, 2023 08:58
@kobayurii
Copy link
Member Author

#115

khorolets
khorolets previously approved these changes Nov 28, 2023
Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've asked to leave a comment around the dependency so we handle the updates when it is possible.

Cargo.toml Show resolved Hide resolved
2. up rust version
3. query.function_call ReadRPC returns error while NEAR RPC succeeds
@kobayurii kobayurii merged commit c83849c into main Nov 28, 2023
3 checks passed
@kobayurii kobayurii mentioned this pull request Nov 28, 2023
@kobayurii kobayurii deleted the func_call branch December 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants