Indexing epochs data #142
Merged
Indexing epochs data #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayurii
force-pushed
the
epoch_indexer
branch
from
e80ae6b to
4a19f3a
Compare
kobayurii
force-pushed
the
epoch_indexer
branch
10 times, most recently
from
5a05c60 to
f9933af
Compare
kobayurii
force-pushed
the
epoch_indexer
branch
2 times, most recently
from
2a1b764 to
7d83419
Compare
khorolets
requested changes
Dec 12, 2023
database/src/postgres/migrations/2023-12-07-144820_epochs/up.sql
Outdated
Show resolved
Hide resolved
database/src/postgres/migrations/2023-12-07-144820_epochs/up.sql
Outdated
Show resolved
Hide resolved
| epoch_id: near_indexer_primitives::CryptoHash, | ||
| ) -> anyhow::Result<readnode_primitives::EpochValidatorsInfo> { | ||
| let epoch = crate::models::Validators::get_validators( | ||
| Self::get_connection(&self.pg_pool).await?, |
There was a problem hiding this comment.
This looks like establishing a connection every time instead of passing an established one. Could you clarify why don't you pass a pg_pool to the function?
There was a problem hiding this comment.
pg_pool - Generic object and connection pool. This struct can be cloned and transferred across thread boundaries and uses reference counting for its internal state.
get_connection - Retrieves a connection from pg_pool or waits for one to become available.
kobayurii
force-pushed
the
epoch_indexer
branch
from
032b915 to
1cfc377
Compare
khorolets
reviewed
Dec 12, 2023
| DATABASE_URL=127.0.0.1:9042 | ||
| DATABASE_USER=cassandra | ||
| DATABASE_PASSWORD=cassandra | ||
| AWS_ACCESS_KEY_ID=AKIAIOSFODNN7EXAMPLE |
There was a problem hiding this comment.
Yes! It takes blocks from s3.
khorolets
reviewed
Dec 12, 2023
kobayurii
force-pushed
the
epoch_indexer
branch
from
1cfc377 to
61cfb84
Compare
khorolets
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant enhancements and new functionalities to the codebase, focusing on improving the indexer's capabilities and implementing new endpoints for enhanced querying:
1. Epoch-Indexer Implementation for Validators and Protocol Configurations:
2. State-Indexer Enhancement for Epochs:
3. Query Function Call Improvement and Bug Fix:
4. Validators Endpoint Implementation:
5. Protocol_Config Endpoint Implementation:
6. Gas_Price Endpoint Implementation:
This pull request signifies a significant stride in augmenting the system's capabilities, refining data retrieval mechanisms, and providing users with enhanced access to critical system information.