feat: add deleteByIdBatch interface and my information #247

shbone · 2023-10-16T03:29:12Z

add my personal information to pom.xml
add add deleteByIdBatch interface function
add relative test module

codecov-commenter · 2023-10-16T03:31:29Z

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (c67c017) 0.00% compared to head (b2ee3d2) 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #247   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          75      75           
  Lines        2563    2563           
  Branches      276     276           
======================================
  Misses       2563    2563

Files	Coverage Δ
...g/nebula/contrib/ngbatis/proxy/NebulaDaoBasic.java	`0.00% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 2d48962.

shbone · 2023-10-16T10:35:00Z

Excuse me! I have a problem. @wey-gu
I only change several lines of code in NebulaDaoBasic.java but there have been
@@ -1,467 +1,487 @@
I don't know how to fix it.

CorvusYe · 2023-10-20T06:56:56Z

src/main/resources/NebulaDaoBasic.xml

+
+    <delete id="deleteByIdBatch">
+        @for ( v in ng_args[0] ) {
+        DELETE VERTEX ${ ng.valueFmt( v )};


The use of passing in multiple ids at the same time may be more appropriate than the use of multiple statement structures.
https://docs.nebula-graph.com.cn/3.6.0/3.ngql-guide/12.vertex-statements/4.delete-vertex/

DELETE VERTEX <vid> [ , <vid> ... ] [WITH EDGE];

OK, I learn that and will change it later!

CorvusYe

Thank you for your efforts and waiting.
That's very elegant.
We can merge without any additional changes.
cc: @wey-gu

CorvusYe · 2023-10-23T17:20:59Z

@shbone
I need to trouble you again to handle the conflict.
And add some infomations in this sections.

ngbatis/CHANGELOG.md

Lines 29 to 44 in c67c017

    
           # NEXT 
        
           ## Dependencies upgrade 
        
           - nebula-java: 3.5.0 -> 3.6.0 
        
           ## Bugfix 
        
           - fix: [#190](https://github.com/nebula-contrib/ngbatis/issues/190) Insert failed when tag has no attributes 
        
           - chore: removing and exclude some packages: log4j related or useless. 
        
           - fix: [#194](https://github.com/nebula-contrib/ngbatis/issues/194) we can name the interface by `@Component` and `@Resource`, for example: 
        
             - `@Component("namedMapper")`: use `@Resource("namedMapper$Proxy")` to inject. (since v1.0) 
        
             - `@Resource("namedComponent")`: use `@Resource("namedComponent")` to inject. (new feature) 
        
           - fix: when DAO/Mapper method has `Page` type param with `@Param`, the param name can not be use. 
        
             > 如原来项目中分页相关接口，用了不起作用的 `@Param`, 但 xml 还是使用 p0, p1... 
        
             > 需要将 `@Param` 移除，或者将 xml 中的参数名改成 注解的参数名，以保证参数名统一

Two PRs should belong to ## Features

Your efforts should be perceived by people.

Thank you vvvvvery much!

shbone · 2023-10-24T02:36:57Z

@shbone I need to trouble you again to handle the conflict. And add some infomations in this sections.

ngbatis/CHANGELOG.md

Lines 29 to 44 in c67c017

# NEXT

## Dependencies upgrade

- nebula-java: 3.5.0 -> 3.6.0

## Bugfix

- fix: [#190](https://github.com/nebula-contrib/ngbatis/issues/190) Insert failed when tag has no attributes

- chore: removing and exclude some packages: log4j related or useless.

- fix: [#194](https://github.com/nebula-contrib/ngbatis/issues/194) we can name the interface by `@Component` and `@Resource`, for example:

- `@Component("namedMapper")`: use `@Resource("namedMapper$Proxy")` to inject. (since v1.0)

- `@Resource("namedComponent")`: use `@Resource("namedComponent")` to inject. (new feature)

- fix: when DAO/Mapper method has `Page` type param with `@Param`, the param name can not be use.

> 如原来项目中分页相关接口，用了不起作用的 `@Param`, 但 xml 还是使用 p0, p1...

> 需要将 `@Param` 移除，或者将 xml 中的参数名改成注解的参数名，以保证参数名统一

Two PRs should belong to ## Features

Your efforts should be perceived by people.

Thank you vvvvvery much!

Thank you ! I will fix this conflict and edit the [ngbatis/CHANGELOG.md]

shbone · 2023-10-24T03:28:59Z

@shbone I need to trouble you again to handle the conflict. And add some infomations in this sections.

ngbatis/CHANGELOG.md

Lines 29 to 44 in c67c017

# NEXT

## Dependencies upgrade

- nebula-java: 3.5.0 -> 3.6.0

## Bugfix

- fix: [#190](https://github.com/nebula-contrib/ngbatis/issues/190) Insert failed when tag has no attributes

- chore: removing and exclude some packages: log4j related or useless.

- fix: [#194](https://github.com/nebula-contrib/ngbatis/issues/194) we can name the interface by `@Component` and `@Resource`, for example:

- `@Component("namedMapper")`: use `@Resource("namedMapper$Proxy")` to inject. (since v1.0)

- `@Resource("namedComponent")`: use `@Resource("namedComponent")` to inject. (new feature)

- fix: when DAO/Mapper method has `Page` type param with `@Param`, the param name can not be use.

> 如原来项目中分页相关接口，用了不起作用的 `@Param`, 但 xml 还是使用 p0, p1...

> 需要将 `@Param` 移除，或者将 xml 中的参数名改成注解的参数名，以保证参数名统一

Two PRs should belong to ## Features

Your efforts should be perceived by people.

Thank you vvvvvery much!

And I am sorry that I don't know why I have this conflict between src/main/java/org/nebula/contrib/ngbatis/proxy/NebulaDaoBasic.java and src/main/resources/NebulaDaoBasic.xml. It is hard for me, whether I should delete the Param and change it to List<> ? Thank you!!

CorvusYe · 2023-10-24T04:39:38Z

This might have something to do with #234 using the master branch and now using another branch?
You can try merging the current master branch into the local.

wey-gu · 2023-10-24T04:45:39Z

Let me give a try on resolving it.

wey-gu · 2023-10-24T05:03:41Z

@shbone Could you double-check check I didn't miss any changes of yours here?

if it looks good, we are good to merge.

I guess the conflict was related to the new line character introduced in a windows env.

shbone · 2023-10-24T07:27:03Z

Yes, I have checked it and all is right

wey-gu · 2023-10-25T09:34:21Z

Let's merge then! :D

Thanks a lot for the great contribution!!!

feat: add deleteByIdBatch interface and my information

9cdbe9c

wey-gu requested a review from CorvusYe October 16, 2023 04:19

wey-gu added Hacktoberfest hacktoberfest-accepted labels Oct 16, 2023

shbone added 2 commits October 16, 2023 18:25

update change format

2d48962

Revert "update change format"

b1b00a0

This reverts commit 2d48962.

CorvusYe reviewed Oct 20, 2023

View reviewed changes

edit deleteByIdBatch delete method

91275ed

shbone requested a review from CorvusYe October 22, 2023 15:22

CorvusYe approved these changes Oct 23, 2023

View reviewed changes

update deleteByIdBatch delete method

4c97021

wey-gu added 2 commits October 24, 2023 12:49

Merge branch 'master' into shb_dev2

be5f3f6

fix change loss in rebasing

b2ee3d2

wey-gu merged commit 70abae2 into nebula-contrib:master Oct 25, 2023

shbone deleted the shb_dev2 branch November 26, 2023 08:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add deleteByIdBatch interface and my information #247

feat: add deleteByIdBatch interface and my information #247

shbone commented Oct 16, 2023

codecov-commenter commented Oct 16, 2023 •

edited

Loading

shbone commented Oct 16, 2023

CorvusYe Oct 20, 2023

shbone Oct 21, 2023

CorvusYe left a comment

CorvusYe commented Oct 23, 2023 •

edited

Loading

shbone commented Oct 24, 2023

shbone commented Oct 24, 2023

CorvusYe commented Oct 24, 2023

wey-gu commented Oct 24, 2023

wey-gu commented Oct 24, 2023

shbone commented Oct 24, 2023

wey-gu commented Oct 25, 2023 •

edited

Loading

feat: add deleteByIdBatch interface and my information #247

feat: add deleteByIdBatch interface and my information #247

Conversation

shbone commented Oct 16, 2023

codecov-commenter commented Oct 16, 2023 • edited Loading

Codecov Report

shbone commented Oct 16, 2023

CorvusYe Oct 20, 2023

Choose a reason for hiding this comment

shbone Oct 21, 2023

Choose a reason for hiding this comment

CorvusYe left a comment

Choose a reason for hiding this comment

CorvusYe commented Oct 23, 2023 • edited Loading

shbone commented Oct 24, 2023

shbone commented Oct 24, 2023

CorvusYe commented Oct 24, 2023

wey-gu commented Oct 24, 2023

wey-gu commented Oct 24, 2023

shbone commented Oct 24, 2023

wey-gu commented Oct 25, 2023 • edited Loading

codecov-commenter commented Oct 16, 2023 •

edited

Loading

CorvusYe commented Oct 23, 2023 •

edited

Loading

wey-gu commented Oct 25, 2023 •

edited

Loading